pack icon indicating copy to clipboard operation
pack copied to clipboard

Support `docker://` URIs for builder lifecycle parameter

Open braunsonm opened this issue 1 year ago • 6 comments

Description

Right now we can provide a docker:// URI for the buildpacks listed in a builder inside the builder.toml but we cannot do the same thing with the lifecycle.

Proposed solution

[lifecycle]
  uri = "docker://buildpacksio/lifecycle:0.18.5"

Describe alternatives you've considered

Right now you need to provide a link to the tar.gz and cannot use docker images.

Additional context

The reason this would be a great quality of life feature is primarily because almost all the other fields in the specification allow docker:// archives. This would be consistent and not require a separate location for storage of the lifecycle binaries. It is a bit inconsistent that at build time you are able to specify a custom lifecycle image, but you can't do the same when you are packaging a builder.

braunsonm avatar Feb 20 '24 20:02 braunsonm

  • The method responsible for fetching the lifecycle during builder creation is here
  • It seems safe to add the corresponding logic to process the new protocol type
  • On the other hand, the logic that handles docker:// when fetching buildpacks is here

jjbustamante avatar Feb 21 '24 12:02 jjbustamante

Hey @jjbustamante, I want to give it a try. Could you please assign this to me?

prashantrewar avatar Feb 22 '24 17:02 prashantrewar

Hi @jjbustamante , I would like to take a look if this is available

rashadism avatar Mar 25 '24 10:03 rashadism

@prashantrewar were you still working on this one, or could @rashadism have it?

natalieparellano avatar Mar 26 '24 15:03 natalieparellano

@natalieparellano, I apologize, I'm busy with something. @rashadism you can feel free to try it.

Thank you!

prashantrewar avatar Mar 27 '24 06:03 prashantrewar

@jjbustamante @natalieparellano Hi can u review the PR

rashadism avatar Apr 01 '24 13:04 rashadism