pack icon indicating copy to clipboard operation
pack copied to clipboard

Use fully qualified image names (podman compatibility)

Open FlorianLudwig opened this issue 3 years ago • 10 comments

Description

For podman compatibility (and more) it would be good to use fully qualified image names ( = include registry in image name)

Example: Instead of:

buildpacksio/lifecycle:0.11.3

use:

docker.io/buildpacksio/lifecycle:0.11.3

Changes

  • [ ] Update internal references to images to include registry
  • [ ] Update docs to use fully qualified image names in examples

Additional context

See also:

  • https://www.redhat.com/en/blog/be-careful-when-pulling-images-short-name
  • https://github.com/buildpacks/pack/issues/966#issuecomment-870689430

FlorianLudwig avatar Jun 29 '21 15:06 FlorianLudwig

Not only podman compatibility, it should be also safer.

matejvasek avatar Jun 29 '21 15:06 matejvasek

I like this suggestion although I know there will be some necessary discussion about ease-of-use considering that there's a large number of users that are coming from the docker CLI where the host is assumed if missing.

jromero avatar Jun 29 '21 19:06 jromero

@jromero

changing:

https://github.com/buildpacks/pack/blob/88c345552c7bfb90ebd3a622e5a16ffdb29e72bd/internal/config/config.go#L130

would not be visible end-user facing. So at least for that part, no ease-of-use consideration would be necessary?

Updating the docs so that all examples include the host might be different.

I do not want to suggest to enforce only accepting image names that contain the host.

FlorianLudwig avatar Jun 30 '21 13:06 FlorianLudwig

@FlorianLudwig I would say that we are on the same page.

  1. We should update the reference to lifecycle image
  2. Update the docs to include host (I am curious how this would affect image names for images that are only intended to live on the docker daemon. I'm assuming you would still set the host to docker.io which might be contentious).
  3. We should NOT enforce only accepting image names that contain a host.

jromero avatar Aug 10 '21 14:08 jromero

I'm thinking about giving it a try. But what's the meaning of the contribfest label? Is there anything that should be considered when working on this issue?

hhiroshell avatar Mar 25 '24 12:03 hhiroshell

@hhiroshell it would be great to get your help on this! Re the label, we flagged this issue for a Contribfest session that we hosted at KubeCon EU, but the issue is still up for grabs.

natalieparellano avatar Mar 26 '24 15:03 natalieparellano

Thanks @natalieparellano, so could you please assign this to me?

hhiroshell avatar Mar 27 '24 07:03 hhiroshell

Now, I'm working on fixing documentation at https://github.com/buildpacks/docs/pull/702.

hhiroshell avatar May 01 '24 09:05 hhiroshell