kpack icon indicating copy to clipboard operation
kpack copied to clipboard

Build contents diff RFC

Open sampeinado opened this issue 4 years ago • 4 comments

Readable

sampeinado avatar Oct 12 '20 15:10 sampeinado

My big existential question on this RFC is if this functionality makes sense as part the kp cli. Up to this point all the functionality in kp has been about interacting with kpack via the kubernetes api. However, this functionality would involve reading and parsing cnb image metadata outside of kpack interaction.

That might be more generally useful as part as another standalone tool or via pack. This diffing is probably useful to the broader cnb ecosystem as well.

matthewmcnew avatar Oct 12 '20 21:10 matthewmcnew

I'd advocate for its inclusion in the kp CLI. A common complaint about the developer experience of using kpack is the need to use other tools in conjunction with kp. Given that this workflow would be very helpful to developers when debugging problems, it makes sense to provide this to them as an available tool without having to look elsewhere.

mgibson1121 avatar Oct 12 '20 22:10 mgibson1121

I think we should include this functionality in kp (working with any CNB-created image tag) regardless of if pack includes it because I don't think it would hurt kps usability by having this feature.

I also think we should have a -o json/yaml flag for this for programatic uses of this feature.

tylerphelan avatar Dec 03 '20 15:12 tylerphelan

What's the status of this RFC? I can see the value of this feature and would throw my +1 on making it a kp feature in that, with my current understanding, it would leverage build information available via kpack (k8s) and not just solely what is available on the images. For example, config/resource changes and build times aren't things that are on the image as far as I'm aware.

jromero avatar Sep 21 '21 18:09 jromero

Closing due to staleness and that this seems better in the kpack cli repo

tomkennedy513 avatar Oct 31 '23 18:10 tomkennedy513