docs icon indicating copy to clipboard operation
docs copied to clipboard

Documentation does not work for github merge queue

Open prestonvanloon opened this issue 1 year ago • 0 comments

This tutorial leaves out an important step that the enables "merge_group" webhook events.

https://buildkite.com/docs/tutorials/github-merge-queue

See github's documentation that says your CI needs to have merge_group with the type checks_requested.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#merge_group

Additionally, enabling Skip builds with existing commits is a bad suggestion for pipelines that run certain jobs only on the main branch. I.e. anything that is triggered after the PR submits won't trigger with this setting on and using merge queue.

Lastly, buildkite's internal documentation for setting up github integrations tells the user to set up the webhook without "merge_group".

Screenshot_2023-12-08_09-37-08

prestonvanloon avatar Dec 08 '23 15:12 prestonvanloon