docker-puppeteer
docker-puppeteer copied to clipboard
Remove wait-for-it.sh from container
Hi,
Could you please remove wait-for-it.sh script from Dockerfile and instead
- add it in to repository and mount it inside the container before tests
- Or download it inside command before tests
https://github.com/buildkite/docker-puppeteer/blob/master/example/docker-compose.integration-tests.yml#L10
It does not look good when something is downloaded from random place. And in this case it is only needed in tests.
Br, Markku
Hi there,
I've only recently started using this package for and I must say, I will be using wait for it in my local environment, so it is a convenience to have it bundled.
On the other hand, it should be maybe pointed out in the Readme, however, the Dockerfile is so small, it takes a second to read through - which is always recommended.