cli icon indicating copy to clipboard operation
cli copied to clipboard

some emoji missing or different set supported?

Open drnic opened this issue 5 years ago • 2 comments

What is bk's relationship with https://github.com/buildkite/emojis?

In the example pipeline below, only :thumbsup: is supported by bk:

steps:
  - command: "sleep 2"
    label: ":thumbsup:"
  - command: "sleep 2"
    label: ":thumbsup::skin-tone-2:"
  - command: "sleep 2"
    label: ":+1:"
  - command: "sleep 2"
    label: ":+1::skin-tone-2:"

The output includes:

>>> Executing command step 👍
...
>>> Executing command step 👍:skin-tone-2:
...
>>> Executing command step :+1:
...
>>> Executing command step :+1::skin-tone-2:

drnic avatar Mar 11 '20 03:03 drnic

Ah, I think I see what's happening. We're not taking into consideration the emoji variations.

The golang version is here: https://github.com/buildkite/cli/blob/e635a7d96563e6488376a0fe942b48f959f94686/local/emoji.go#L72-L96

Which just looks up the emoji in the list, but in the Ruby version, there's some pre-processing going on: https://github.com/buildkite/docs/blob/master/app/models/emoji/catalogue.rb#L34-L49

I don't have time to craft a fix, but a PR would be welcome! :D:D

keithpitt avatar Mar 11 '20 05:03 keithpitt

Ok will investigate later.

I want my pipelines to have randomized skin color :)

drnic avatar Mar 12 '20 00:03 drnic

👋 We don't currently support a local run command in the new CLI version (3.x.x). As you've seen, there are some complexities around having a local run command in the CLI and we're looking at other methods of providing this functionality.

mcncl avatar Sep 29 '24 10:09 mcncl