agent-stack-k8s icon indicating copy to clipboard operation
agent-stack-k8s copied to clipboard
verified publisher icon buildkite

Allow extraVolumeMounts with podSpecPatch

Open bpoland opened this issue 1 year ago • 1 comments

👋 with the podSpecPatch functionality introduced in https://github.com/buildkite/agent-stack-k8s/pull/282 I'd really like to be able to specify default volumes to mount to all containers (e.g. the extraVolumeMounts available without the patching. Is this something that could be added? Maybe an extra-volume-mounts to define in the controller helm values?

I want to use this to mount an agent hooks volume as well as pipeline signing keys. Thanks!

bpoland avatar May 16 '24 14:05 bpoland

kia ora @bpoland! this would be a useful feature to have in the k8s stack, and we'll it to our backlog. in the meantime, we would happily accept PRs to this effect. if you want to reach out to me or @DrJosh9000 on slack, we can potentially help you out with implementation stuff, if you're interested.

moskyb avatar May 22 '24 03:05 moskyb

Likely a better solution would be to allow volumeMounts to be added to the default-(checkout|command|sidecar)-params blocks like envFrom is?

bpoland avatar Jan 21 '25 16:01 bpoland