docker-compose-buildkite-plugin
docker-compose-buildkite-plugin copied to clipboard
buildkite-plugins
Support multiple `version` keys in docker-compose config
Context
The plugin has trouble working with docker-compose.yml files where there are multiple version entries. See #315.
Change
Alter the file parsing to consider only the first version entry it finds. Fixes #315.
Hey @orien! Thank you for your contributions and sorry for the delay 🙏🏻 We'll review it soon and we'll keep you posted 🙂
@orien, thanks a lot for your patience on this. We have finally gotten around to this and found that we would like to make a few minor improvements to your code. Would you be able to allow our contributions to the PR?
Hi @toote, 👋 Thanks for looking into this.
Would you be able to allow our contributions to the PR?
Unfortunately, I don't have this option. Perhaps because the source repo is in the @envato account rather than my personal one.
@orien thanks for the quick response.
That means I'll have to close this PR and create a new one (will make sure to keep your commits for proper attribution, thoug). It may take us a while because we will probably bundle this change (or merge close together) with the ones in #307 as they both deal with dockerfile versions.