docker-compose-buildkite-plugin icon indicating copy to clipboard operation
docker-compose-buildkite-plugin copied to clipboard

Retry on Docker failure

Open nijave opened this issue 5 years ago • 2 comments

Occasionally the Docker daemon will fail (usually due to heavy load). Is there any way to set a retry on this? It looks like the only options are on image operations

nijave avatar Jul 02 '19 15:07 nijave

Sounds like the pull-retries and push-retries options might be what you need @nijave?

toolmantim avatar Jul 17 '19 03:07 toolmantim

These aren't pulls or pushes, they're the actual build (docker-compose build) so I don't think those will have any effect

On Tue, Jul 16, 2019, 11:59 PM Tim Lucas [email protected] wrote:

Sounds like the pull-retries and push-retries options might be what you need @nijave https://github.com/nijave?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/issues/227?email_source=notifications&email_token=AAC53WTUMFGPGQNLCPLYKNTP72KLNA5CNFSM4H4453F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2C6TAI#issuecomment-512092545, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC53WUQYK4B32LC2C4ON2DP72KLNANCNFSM4H4453FQ .

nijave avatar Jul 17 '19 10:07 nijave

Adding the logic to be able to do that may be quite cumbersome for little gain. Flaky tests are the bane of every engineer so I completely understand how frustrating they can be. Unfortunately, I believe they are a symptom of an issue and retries are not a solution just a bandaid.

That said, buildkite does offer some alternatives: you can retry the step itself off buildkite's UI or using steps' retry attributes for it to be done automatically.

toote avatar Sep 21 '22 03:09 toote