docker-compose-buildkite-plugin icon indicating copy to clipboard operation
docker-compose-buildkite-plugin copied to clipboard

Container logs not always uploading

Open uriahcarpenter opened this issue 6 years ago • 3 comments

When any of the compose services fail it's expected that container logs be uploaded as artifacts.

v1.8.4 fixed an issue where logs would not get uploaded.

For a docker compose build that is erroring, I reproduced the following behavior from these three versions:

v1.8.3 --> Logs not uploaded v1.8.4 --> Logs uploaded okay v2.0.0 --> Logs not uploaded

uriahcarpenter avatar Apr 04 '18 18:04 uriahcarpenter

Sorry about this @uriahcarpenter, we'll get some tests in place to catch this regression.

lox avatar Apr 04 '18 22:04 lox

Hi @lox. I'm no longer convinced that it's just a plain regression. Even with v1.8.4 I don't always get logs.

1.8.4 okay

SAME exact Git hash... but 1.8.4 with no logs

uriahcarpenter avatar Apr 04 '18 22:04 uriahcarpenter

I've suspected a race condition for container logs for a while. We'll investigate.

lox avatar Apr 04 '18 22:04 lox

Given the timing, I suspect this is a duplicate of #78. Same as there, logs appear to have been running without issues for a while now so I am closing this one for the time being

toote avatar Sep 21 '22 02:09 toote