Sample-Test-Files icon indicating copy to clipboard operation
Sample-Test-Files copied to clipboard

UT_IfcAlignment_IfcCourse_IfcSectionedSolidHorizontel

Open BernhardWehrle opened this issue 4 years ago • 3 comments

Changes

  • IfcAlignment now with Ifc4X3_RC2
  • Renamed the files in UT_IfcAlignment_IfcCourse_IfcSectionedSolidHorizontel.*
  • Set the correctly scheme FILE_SCHEMA (('IFC4X3_RC2'));
  • Set the correctly filename FILE_NAME ('UT_IfcAlignment_IfcCourse_IfcSectionedSolidHorizontel.ifc',
  • Set a GUID for IfcAlignmentHorizontal #35 = IFCALIGNMENTHORIZONTAL('397AcFNgJJlq9EY2eHiJZv', $, $, $, $, $, $, 0., $);
  • Set correcty UTM-Coordinates for alignment (see Google-Earth import Shapefile) #38 = IFCCARTESIANPOINT((513210., 5454110.)); #41 = IFCCARTESIANPOINT((513210., 5454110.));
  • Update documentation

ATTENTION: This template provides structure for

  • a general pull request and
  • a specific pull request in scope of IFC4.3 validation work within IFC Infrastructure Extension Deployment project. Please fill in the corresponding section(s) and delete the rest.

General pull request

Fixes # . reference the issue fixed through this pull request

Changes and improvements proposed by this pull request

  • list all functions / files / changes you have made

Use @[username] to gain attention by potential reviewers.

IFC4.3 Unit test

Unit test

provide a short description

Review requested

  • List all functions/concepts/entities you have added/changed/improved

@pjanck

Link to external documentation

optional

Instructions

  • provide a descriptive title

Added new UT <UnitTestName> with supporting documentation Expanded UT <UnitTestName> with ... Corrected / Amended / Updated ...

  • prepend the title with [UT] <title> to enable easier management
  • mark as WIP if work in progress

WIP: [UT]

  • label the pull request with infra depl
  • please set at least @pjanck as a reviewer and add others as needed
  • delete this section

BernhardWehrle avatar Jan 27 '21 07:01 BernhardWehrle

Do you want only a IFC-File?

AKG Software Consulting GmbH Bernhard Wehrle Entwicklung

Uhlandstraße 12 79423 Heitersheim Germany

Tel.: +49 (0)7634 5612-0 Fax: +49 (0)7634 5612-300 E-Mail: [email protected] Internet: www.akgsoftware.dehttp://www.akgsoftware.de

Geschäftsführer: Dipl.-Ing. Artur K. Günther, Dipl.-Ing. Arno Brüggemann, Dipl.-Ing. (FH) Bernhard Feser, Dipl.-Ing. Jens Günther Sitz der Gesellschaft: Heitersheim, HRB 310383 (Amtsgericht Freiburg)


Von: Stefan Jaud [email protected] Gesendet: Donnerstag, 28. Januar 2021 09:58 An: buildingSMART/Sample-Test-Files [email protected] Cc: Bernhard Wehrle [email protected]; Author [email protected] Betreff: Re: [buildingSMART/Sample-Test-Files] UT_IfcAlignment_IfcCourse_IfcSectionedSolidHorizontel (#101)

Externe E-Mail: Vorsicht beim Öffnen von Anhängen und Klicken auf Links!

@pjanck requested changes on this pull request.

I really like the many different formats submitted for reference!

One request: please use IfcSectionedSolidHorizontal consistently - sometimes you use "horizontAl", sometimes "horizontEl" - the correct one would be the former.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/buildingSMART/Sample-Test-Files/pull/101#pullrequestreview-578109799, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJHOJH5TZGF6J5O6V7MGRX3S4ERMTANCNFSM4WUY64RA.

BernhardWehrle avatar Jan 28 '21 10:01 BernhardWehrle

Hi Bernhard,

other files are very welcome! I think that this way others will be able to double-check their implementations accordingly.

My comment was addressing the typos in your readme and file names. Sometimes you've used "E", sometimes an "A" (correct) in IfcSectionedSolidHorizont*l.

pjanck avatar Feb 01 '21 09:02 pjanck

We're moving to the new repository: https://github.com/bSI-InfraRoom/IFC-infra-unit-test

Please open a new pull request there and close this one.

pjanck avatar Feb 11 '21 16:02 pjanck