NextGen-IFC icon indicating copy to clipboard operation
NextGen-IFC copied to clipboard

Deprecating layers

Open SergejMuhic opened this issue 4 years ago • 9 comments

These are, in my view, a bit outdated concepts. They do have a place in assigning styles, so maybe merge IfcPresentationLayerAssignment and IfcPresentationLayerWithStyle?

SergejMuhic avatar Mar 05 '20 08:03 SergejMuhic

I would opt for removing IfcPresentationLayerWithStyle - as of IFC4 it is deprecated to use it for applying style (colour), in order to reduce the already too many different ways to do so. So it should not be used anymore.

IfcPresentationLayerAssignment - although one can argue that the time for CAD layers has long passed, they are still used in practise. Maybe we need to keep it?

TLiebich avatar Mar 05 '20 13:03 TLiebich

This is an excellent example of something that needs further discussion and feedback from the ISG members... who will be meeting in a week’s time.

A reminder that the other issues will need their input as well.

On Thu, Mar 5, 2020 at 7:48 AM Thomas Liebich [email protected] wrote:

I would opt for removing IfcPresentationLayerWithStyle - as of IFC4 it is deprecated to use it for applying style (colour), in order to reduce the already too many different ways to do so. So it should not be used anymore.

IfcPresentationLayerAssignment - although one can argue that the time for CAD layers has long passed, they are still used in practise. Maybe we need to keep it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/buildingSMART/NextGen-IFC/issues/25?email_source=notifications&email_token=ABR3VKCUVXHYZXHMN4SCCALRF6URZA5CNFSM4LCESIO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN5J5HQ#issuecomment-595238558, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABR3VKF3ENOLUPSMYWU3TB3RF6URZANCNFSM4LCESIOQ .

-- — Best regards, Jeffrey W. Ouellette Progress Advocate for the Built Asset Industry Providing global services from Austin, TX

jwouellette avatar Mar 05 '20 14:03 jwouellette

@jwouellette - sure, and this applies to all - we should not decide major steps without getting back to our "customers", the software industry, first.

TLiebich avatar Mar 05 '20 18:03 TLiebich

All of the issues in this repo need active involvement from implementors. Inside and outside ISG.

berlotti avatar Mar 05 '20 18:03 berlotti

I would opt for removing IfcPresentationLayerWithStyle - as of IFC4 it is deprecated to use it for applying style (colour), in order to reduce the already too many different ways to do so. So it should not be used anymore.

IfcPresentationLayerAssignment - although one can argue that the time for CAD layers has long passed, they are still used in practise. Maybe we need to keep it?

I cannot remember seeing an IFC file with layers for quite some time now. I assumed they might be used for assigning styles still. So, yes I agree, this is a topic to be discussed.

SergejMuhic avatar Mar 06 '20 08:03 SergejMuhic

@TLiebich bS is supported by different stakeholder-groups, not only by software industry. I aggree that major steps need alignment with software industry to ensure feasibility and consensus. But please keep on with visionary and courageous proposals to ensure progress and to declutter outdated parts of the concept. Prominent supporters of bS expect significant progress to justifiy their contributions, I have heard. We need a good compromise between sufficient progress and economic viability.

HerbertDobernig avatar Mar 08 '20 10:03 HerbertDobernig

Every ifc file I have seen from any of the major BIM authoring tools supports this. Many viewers provide a tree view to use them. I don’t see any particular reason to remove them. It is useful to transfer a part of the information in these applications via ifc. Even Revit which does not rely on layers transmits layers using its CAD mapping.

stefkeB avatar Mar 08 '20 22:03 stefkeB

As a conclusion, I would propose to remove IfcPresentationLayerWithStyle, but keep IfcPresentationLayerAssignment . The second is still used today on a daily basis, see also @stefkeB comment, the first is outdated and should also be removed in order to simplify the styling (coloring) of components.

TLiebich avatar Mar 09 '20 12:03 TLiebich

check list for removing IfcPresentationLayerAssignment

what do we win

  • less redundency and less variations for assigning style information to shapes

what do we loose

  • nothing

schema impact

  • minor (essentially updating documentation)

instance model impact

  • none

backwards compatibility impact

  • none (does not change), for old files easy downcasting to supertype IfcPresentationLayerAssignment

automatic migration possible

  • yes

TLiebich avatar Mar 09 '20 12:03 TLiebich