IFC4.3.x-development icon indicating copy to clipboard operation
IFC4.3.x-development copied to clipboard

IfcPresentationLayerWithStyle.ApplicableOnlyToItems case sensitivity issue

Open I-Sokolov opened this issue 1 year ago • 4 comments

I think this is issue in schema, entity name must be in capital letters.

ENTITY IfcPresentationLayerWithStyle SUBTYPE OF (IfcPresentationLayerAssignment); LayerOn : IfcLogical; LayerFrozen : IfcLogical; LayerBlocked : IfcLogical; LayerStyles : SET [0:?] OF IfcPresentationStyle; WHERE ApplicableOnlyToItems : SIZEOF(QUERY(temp <* AssignedItems | (SIZEOF(TYPEOF(temp) * ['IFC4X3_ADD2.IfcGeometricRepresentationItem','IFC4X3_ADD2.IfcMappedItem']) >= 1))) = SIZEOF(AssignedItems); END_ENTITY;

Please refer to ISO_10303-11

8.1.6 String data type … The case (upper or lower) of letters within a string is significant

15.25 TypeOf - general function …returned set of string values are the names (in upper case)…

I-Sokolov avatar Nov 09 '23 06:11 I-Sokolov

Ah a rule newly introduced in 4.1. Excellent also to have the relevant wording from the spec. Thanks you!

If we do another TC for 4.3 I'll also make sure it gets included.

I'll write a verification script for this to check this for 4.4. I've had several occasions where I made the same mistake (but got detected in time).

aothms avatar Nov 09 '23 08:11 aothms

Hi @I-Sokolov and @aothms, is it maybe an idea to add such recognized warnings to the validation output? For the known cases in existing schemas we need to make some exclusions as it will otherwise always raise issues. The benefit is that whenever we work on a new schema we will find it directly.

peterrdf avatar Nov 09 '23 08:11 peterrdf

add such recognized warnings to the validation output

@peterrdf This is something that has come up in the discussions. Some sort of a whitelist of errors. For example we had some actual schema attribute range errors in #488. That would have also been an excellent candidate for this whitelist.

CC @evandroAlfieri I think we should put this on the roadmap.

aothms avatar Nov 09 '23 08:11 aothms

This should be validation of schema, not data file validation imho

I-Sokolov avatar Nov 30 '23 05:11 I-Sokolov