IFC4.3.x-development icon indicating copy to clipboard operation
IFC4.3.x-development copied to clipboard

Documentation of the IFCALIGNMENTHORIZONTAL is not up-to-date.

Open aothms opened this issue 2 years ago • 4 comments

Also, the latest documentation of the IFCALIGNMENTHORIZONTAL is IMO not up-to-date.
ENTITY IfcAlignmentHorizontal SUBTYPE OF (IfcLinearElement); END_ENTITY;

where IfcLinearElement is ENTITY IfcLinearElement SUPERTYPE OF (ONEOF (IfcAlignmentCant ,IfcAlignmentHorizontal ,IfcAlignmentSegment ,IfcAlignmentVertical)) SUBTYPE OF (IfcProduct); END_ENTITY;

The example IFC-file related to this is based on IFC4X3_RC2 #28 = IFCALIGNMENTHORIZONTAL('1FahSvf2z8YeREQCzieDuo', #2, 'Horizontal Alignment', '12d Horizontal Alignment', $, $, $, 0., (#29, #31, #33));

This seems to apply to most of the alignment classes.

Originally posted by @HannuLahtela in https://github.com/buildingSMART/IFC4.3.x-development/issues/488#issuecomment-1162676669

aothms avatar Jun 22 '22 06:06 aothms

@peterrdf @berlotti were there any plans for this to regenerate the sample files according to the final schema?

aothms avatar Jun 22 '22 06:06 aothms

@aothms , we have a set of artificial test files for IFC4.3, you can find them here: https://github.com/IFCRail/IFC-Rail-Unit-Test-Reference-Code/tree/master/alignment_testset/IFC-WithGeneratedGeometry I am not sure what is the status for IFC4.3 real life test files, there are several larger files available that are well tested against the new schema but I think they cannot be public because of their content, Evandro would be the right person to ask I think.

note that we are still finding issues in the example files now and then, this as several software vendors are actively implementing support for IFC4.3 and they are coming back with valuable comments and issues. The latest change is from one week ago, but this week another bug will be fixed in the example files referenced above.

peterrdf avatar Jun 22 '22 06:06 peterrdf

Thanks @peterrdf

@evandroAlfieri do you think it's possible to create a subset of the unit tests as example files in the main spec?

We currently have this:

http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/annex-e.html

Generated from:

https://github.com/buildingSMART/Sample-Test-Files/tree/master/IFC%204.3

Last commit: years ago. That's really unacceptable.

We also need to regenerate the IFC4 sample files in accordance with the new schema. That task I can take on.

aothms avatar Jun 22 '22 07:06 aothms

@aothms a part of the upcoming IFC 4.3 Implementers Forum is a pool of good, up-to-date sample 4.3 files. I'm on it in these days. Btw, updating existing test files is certainly an option

evandroAlfieri avatar Jul 08 '22 14:07 evandroAlfieri