Functions are out of date

[SergejMuhic]

Had a look and it seems none of the updates from the Infra and Rail projects are incorporated.

[aothms]

@SergejMuhic

I did a comparison between 4.3.x-dev generated and Infra RC4-Update and I found the 'Segment' case missing in IfcShapeRepresentationTypes are you referring to other things I'm unaware of?

[SergejMuhic]

From the top of my head:

1. IfcDimensionsForSIUnit, the 'I' in 'SI' was capitalized to make it consistent.
2. IfcShapeRepresentationTypes 'Sectioned Surface' was added (added no issue last week because the functions were not published at the time)

Cannot remember others but I think there might have been something in the geometric stuff still.

[aothms]

1. Maybe you forgot to update it in the derived attribute. But you're lucky express is case-insensitive ;) https://github.com/bSI-InfraRoom/IFC-Specification/blob/ab34efbc212fe119f1bc49aef8f66a43a268245b/IFC4x3/Sections/Resource%20definition%20data%20schemas/Schemas/IfcMeasureResource/Entities/IfcSIUnit/DocEntity.xml#L19

Cannot remember others but I think there might have been something in the geometric stuff still.

From the looks of it it appears we have everything

$ git log --name-only -- '*Functions*'
commit 0863df21446ced3697f38c460f98390798176f78
Author: SergejMuhic <[email protected]>
Date:   Tue Nov 23 11:32:01 2021 +0100

    Capitalizing SI in function definition

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit/DocFunction.xml

commit 76f4e30a36a4c22c18781f5fd32546df1a57b5a2
Author: larswik <[email protected]>
Date:   Tue Nov 2 11:54:11 2021 +0100

    IfcShapeRepresentationTypes (SectionedSurface Rep type) & IfcShapeRepresentation indentation

    Added SectionedSurface to IfcShapeRepresentationTypes (please check).
    Indentations of Curve2D, Curve3D, Surface2D, Surface3D in the RepresentationType table
    Added SectionedSurface under Surface as a new RepresentationType.

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcRepresentationResource/Functions/IfcShapeRepresentationTypes/Expression.txt

commit ea1bf31627350a7008e57364fb61e70ca56f4161
Author: czapplitec <[email protected]>
Date:   Fri Sep 24 11:00:13 2021 +0200
    Added SectionedSurface to IfcShapeRepresentationTypes (please check).
    Indentations of Curve2D, Curve3D, Surface2D, Surface3D in the RepresentationType table
    Added SectionedSurface under Surface as a new RepresentationType.

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcRepresentationResource/Functions/IfcShapeRepresentationTypes/Expression.txt

commit ea1bf31627350a7008e57364fb61e70ca56f4161
Author: czapplitec <[email protected]>
Date:   Fri Sep 24 11:00:13 2021 +0200

    RepresentationType "Segment"

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcRepresentationResource/Functions/IfcShapeRepresentationTypes/Expression.txt

commit 6449597f53ec8bc8b26dd6dcc1bb47ee584ee425
Merge: 52544b50 f054355c
Author: SergejMuhic <[email protected]>
Date:   Thu Aug 26 20:17:23 2021 +0200

    Merge branch 'develop' into pr/196

commit f054355c10d3e14d7b58e330a13d5f4423b33fd9
Author: SergejMuhic <[email protected]>
Date:   Thu Aug 26 20:12:11 2021 +0200

    Now the fix

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit/DocFunction.xml
IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit/Documentation.md
IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit/Expression.txt

commit 0940056687e0a6fa9c9a78dbf1f43fa6726bb4c8
Author: SergejMuhic <[email protected]>
Date:   Thu Aug 26 20:11:55 2021 +0200

    Have to commit a name change in order to have the right capitalization

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit0/DocFunction.xml
IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit0/Documentation.md
IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSIUnit0/Expression.txt

commit fe1881153e43f110627f151dfe4e8f8e12dbfe60
Author: apinzenoehler <[email protected]>
Date:   Tue Jul 27 21:36:04 2021 +0200

    IfcSIUnit spelling corrected

    Wrong spelling IfcSiUnit (mixed case "Si") replaced with correct spelling IfcSIUnit (upper case "SI")
    Corrected Definition of Function IfcDimensionsForSiUnit: IfcSIUnitName instead of IfcSiUnitName

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcMeasureResource/Functions/IfcDimensionsForSiUnit/Expression.txt

commit c6c3aa89bb6df0e32813a002cbb5683d08b94521
Author: SergejMuhic <[email protected]>
Date:   Thu Apr 22 09:47:32 2021 +0200

    Fixing typos and parenthesis

IFC4x3/Sections/Resource definition data schemas/Schemas/IfcGeometryResource/Functions/IfcCurveDim/Expression.txt

From thereon onwards everything appears to be included in RC4-Update

[SergejMuhic]

1. Maybe you forgot to update it in the derived attribute. But you're lucky express is case-insensitive ;)

Aw, shit happens. 😄 Was not undertaken by me though, I just updated the paths but I should have reviewed better also.

From thereon onwards everything appears to be included in RC4-Update

Sounds great.