IFC4.3.x-development icon indicating copy to clipboard operation
IFC4.3.x-development copied to clipboard

IfcTransportElement Pset_TransportElementCommon properties need to be audited for applicability

Open Moult opened this issue 2 years ago • 4 comments

Who deleted it? Why? What's the alternative?

Moult avatar Mar 05 '22 04:03 Moult

http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/Pset_TransportElementCommon.htm ?

Edit: applicability is on the abstract superytpe

aothms avatar Mar 05 '22 08:03 aothms

Ah right, so since there is a new vehicle subtype, I think these properties may not necessarily make sense anymore. For example there is FireExit which works for Fire Lifts, but maybe not applicable to vehicles.

The description is wrong (see #419 ) and it is a leaf class (#160) so we should consider whether we should have properties on it.

Maybe something to put on hold until we get some domain experts to review the whole vertical transport domain vs vehicular transport vs temporary construction logistics stuff.

Moult avatar Mar 05 '22 08:03 Moult

Agreed. We can also make it only applicable to IfcTransportElement if you feel better about it. We should then check the infra repo what the state was at that point. But I think it's ok'ish like this.

aothms avatar Mar 05 '22 08:03 aothms

My preference in the short term and not a domain expert is to change the applicability to IfcTransportElement because 1) it used to be there, so to the best of our knowledge it was correct to be there and 2) leaf properties seems to be the convention.

In the long term, a domain expert needs to review.

Moult avatar Mar 05 '22 08:03 Moult