IFC4.3.x-development
IFC4.3.x-development copied to clipboard
buildingSMART
MEP pset refinements
| pset/prop | prop type | prop value type |
|---|---|---|
| Pset_FittingBend (renamed from Pset_PipeFittingTypeBend) | ||
| IfcDuctFitting/BEND IfcCableCarrierFitting/BEND IfcPipeFitting/BEND | ||
| BendAngle | singlevalue | IfcPlaneAngleMeasure |
| BendRadius | singlevalue | IfcPositiveLengthMeasure |
| Pset_FittingJunction (renamed from Pset_PipeFittingTypeJunction) | ||
| IfcDuctFitting/JUNCTION IfcCableFittingTypeEnum/JUNCTION IfcPipeFitting/JUNCTION | ||
| JunctionLeftAngle | singlevalue | IfcPlaneAngleMeasure |
| JunctionRightAngle | singlevalue | IfcPlaneAngleMeasure |
| JunctionLeftRadius | singlevalue | IfcPositiveLengthMeasure |
| JunctionRightRadius | singlevalue | IfcPositiveLengthMeasure |
| JunctionType | enumeratedvalue | PEnum_FittingJunctionType (renamed from PEnum_PipeFittingJunctionType) |
| Pset_FittingTransition (new pset) | ||
| IfcDuctFitting/TRANSITION IfcCableFittingTypeEnum/TRANSITION IfcPipeFitting/TRANSITION | ||
| NominalLength | singlevalue | IfcPositiveLengthMeasure |
| EccentricityInY | singlevalue | IfcLengthMeasure |
| EccentricityInZ | singlevalue | IfcLengthMeasure |
| Pset_ElementSize (new pset) | ||
| IfcDistributionChamberElement IfcEnergyConversionDevice IfcFlowController IfcFlowMovingDevice IfcFlowStorageDevice IfcFlowTerminal IfcFlowTreatmentDevice | ||
| NominalLength | singlevalue | IfcPositiveLengthMeasure |
| NominalWidth | singlevalue | IfcPositiveLengthMeasure |
| NominalHeight | singlevalue | IfcPositiveLengthMeasure |
| Remove NominalWidth and NominalHeight from | ||
| Pset_CableCarrierSegmentTypeCableLadderSegment | ||
| Pset_CableCarrierSegmentTypeCableTraySegment | ||
| Pset_CableCarrierSegmentTypeCableTrunkingSegment | ||
| Pset_CableCarrierSegmentTypeConduitSegment |
agree, those are long outstanding issues question: how do we handle similar issues of duplicates for building elements within the pset_xxxcommon?
Pset_CableCarrierSegmentTypeConduitSegment still seems to have nominal width / height?
JunctionLeftRadius and JunctionRightRadius should be IfcLengthMeasure not IfcPositiveLengthMeasure to allow for radius = 0 for sharp corners?
Similarly, now that nominal width / height has been removed, CableCarrierSegmentType has no dimensional nomination (apart from conduit segment which still exists). Should Pset_ElementSize be applicable to it? I guess this is part of #233.
Hi @aothms cc @TLiebich
You've removed NominalWidth and NominalHeight from Pset_CableCarrierSegmentType*** psets, and the new Pset_ElementSize is not applicable for IfcCableCarrierSegment. Is this intended?
The documentation for the CableCarrier psets says that it is "To be handled as a quantity measure", but I don't see any place to put this information anymore. We'll therefore have to provide custom property sets for storing width and height for our cable ladders and trays.
@Moult Ah, sorry, you are totally correct. I didn't read the last paragraph of your comment. Regard my comment as a reminder/bump then.
thanks for bringing it up. It seems unintentional. When I check the applicable entities for Pset_ElementSize I also wonder, why not just using IfcDistributionElement to cover all (it can even be discussed to assign it to IfcElement, since other building elements also have nominal lenght, width, height being potentially different to geometrically correct lenght, width, heigth.
http://ifc43-docs.standards.buildingsmart.org/IFC/RELEASE/IFC4x3/HTML/lexical/Pset_ElementSize.htm
Also bumping this that duct currently has shapes for RECTANGULAR, FLATOVAL, ROUND, whereas pipes assume all pipes are circles which is not true (e.g. many downpipes are rectangular).