Incorrect Relationships for Test Case File "The containment can be indirect 2/2"

Open giuseppeverduciALMA opened this issue 1 year ago • 1 comments

The .ifc file for the test case "The containment can be indirect 2/2" (partof/fail-the_containment_can_be_indirect_2_2.ifc) contains errors in the relationships:

Line #3: IFCRELAGGREGATES -> IFCRELCONTAINEDINSPATIALSTRUCTURE
Line #5: IFCRELCONTAINEDINSPATIALSTRUCTURE -> IFCRELAGGREGATES

For both relationships, the last two attributes need to be swapped.

Additionally, it is necessary to verify the associated .ids file (relation attribute of partOf) to ensure it aligns correctly with the intent.

Nov 19 '24 08:11 giuseppeverduciALMA

Agree, the test is wrong, mistake made in this commit https://github.com/buildingSMART/IDS/commit/3345939befc669dacbcc5be27ed2888ec3a579fc

Nov 26 '24 20:11 Moult

@giuseppeverduciALMA is it easy for you to write a PR?

Apr 20 '25 21:04 CBenghi

@giuseppeverduciALMA is it easy for you to write a PR?

Hi @CBenghi, I just opened the PR for this issue: #407

Apr 22 '25 08:04 giuseppeverduciALMA