IDS icon indicating copy to clipboard operation
IDS copied to clipboard

Remove the outdated "implementation agreement" comment lines from the schema

Open pasi-paasiala opened this issue 1 year ago • 4 comments

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

Here are still the lines, if the line number mentioned above doesn't work due to changes to the file:

		<!-- Please note there is an implementation agreement on the use of minOccurs and maxOccurs.
			Valid values are: 
			a. 0 to unbounded, meaning Optional
			b. 1 to unbounded, meaning Required
			c. 0 to 0, meaning Prohibited
		 -->

pasi-paasiala avatar Mar 08 '24 07:03 pasi-paasiala

Also the first line:

<!-- Draft - Do not use in production -->

should be removed.

pasi-paasiala avatar Mar 18 '24 13:03 pasi-paasiala

Hi @pasi-paasiala, we will remove the draft comment when freezing and updating the version number. Is that ok?

CBenghi avatar Mar 24 '24 14:03 CBenghi

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

I think the comment is valid, and relevant.

CBenghi avatar Mar 24 '24 14:03 CBenghi

The lines starting from here should be removed, since they're outdated. https://github.com/buildingSMART/IDS/blob/master/Development/ids.xsd#L67

I think the comment is valid, and relevant.

True. I didn't realize that this was a recent change.

pasi-paasiala avatar Apr 10 '24 05:04 pasi-paasiala

fixed

berlotti avatar Jun 03 '24 08:06 berlotti