buildbot-infra icon indicating copy to clipboard operation
buildbot-infra copied to clipboard

Mailing list posts are flagged as spam

Open djmitche opened this issue 6 years ago • 4 comments

screenshot_2019-02-05 devel bb net buildbot weekly summary - djmitche gmail com - gmail

djmitche avatar Feb 05 '19 17:02 djmitche

Here's one in English, for a message we very much did not want to miss

screenshot_2019-02-05 crlf injection in auth logout redirect - djmitche gmail com - gmail

djmitche avatar Feb 05 '19 17:02 djmitche

The buildbot.net domain doesn't have SPF set and I think its reverse resolve is wrong.

$ dig buildbot.net
...
;; ANSWER SECTION:
buildbot.net.           86400   IN      A       140.211.10.238
...
$ dig -x 140.211.10.238
...
;; ANSWER SECTION:
238.10.211.140.in-addr.arpa. 3600 IN    CNAME   238.128-255.10.211.140.in-addr.arpa.
238.128-255.10.211.140.in-addr.arpa. 86399 IN CNAME 238.224-255.128-255.10.211.140.in-addr.arpa.
238.224-255.128-255.10.211.140.in-addr.arpa. 86399 IN PTR www.buildbot.net.224-255.128-255.10.211.140.in-addr.arpa.
...

seankelly avatar Feb 06 '19 15:02 seankelly

#223 did not apply:

failed: [localhost] (item=224-255.128-255.10.211.140.in-addr.arpa) => {"changed": false, "item": "224-255.128-255.10.211.140.in-addr.arpa", "msg": "AnsibleError: template error while templating string: unexpected '}'. String: @       86400   IN      SOA     ns1.buildbot.net. hostmaster.buildbot.net. (\n                                        {{ dns_serial }}      ;serial\n                                        10800           ;refresh\n                                        1800            ;retry\n                                        604800          ;expire\n                                        86400   )       ;minimum\n@               7200    IN      NS      c.ns.buddyns.com.   ; germany\n@               7200    IN      NS      f.ns.buddyns.com.   ; india\n@               7200    IN      NS      ns1.rtems.org.      ; usa\n@               7200    IN      NS      ns1.darkbeer.org.   ; usa\n\n{% for name, ip in hosts_ips.items() %}\n{% if name == \"www\" -%}\n{{ip}      86400   IN       PTR     buildbot.net.\n{% else -%}\n{{ip}}     86400   IN       PTR     {{name}}.buildbot.net.\n{% endif -%}\n{% endfor %}\n"}
        to retry, use: --limit @/home/bbinfra/repo/local.retry

djmitche avatar Feb 21 '19 18:02 djmitche

OK!

dustin@jemison ~ $ dig -tptr @ns1.buildbot.net 238.224-255.128-255.10.211.140.in-addr.arpa.

; <<>> DiG 9.11.4-P2-RedHat-9.11.4-13.P2.fc29 <<>> -tptr @ns1.buildbot.net 238.224-255.128-255.10.211.140.in-addr.arpa.
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 33992
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 4, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;238.224-255.128-255.10.211.140.in-addr.arpa. IN        PTR

;; ANSWER SECTION:
238.224-255.128-255.10.211.140.in-addr.arpa. 86400 IN PTR buildbot.net.
dustin@jemison ~ $ dig @ns1.buildbot.net www.buildbot.net

; <<>> DiG 9.11.4-P2-RedHat-9.11.4-13.P2.fc29 <<>> @ns1.buildbot.net www.buildbot.net
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 16948
;; flags: qr aa rd; QUERY: 1, ANSWER: 2, AUTHORITY: 4, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;www.buildbot.net.              IN      A

;; ANSWER SECTION:
www.buildbot.net.       86400   IN      CNAME   buildbot.net.
buildbot.net.           86400   IN      A       140.211.10.238

so the reverse DNS is fixed now. DKIM is #224.

djmitche avatar Feb 21 '19 18:02 djmitche