ockam icon indicating copy to clipboard operation
ockam copied to clipboard

chore: fix the create inlet help message

Open ivor11 opened this issue 1 year ago • 5 comments

Current behavior

Current rust doc comment for creating a TCP inlet: Create TCP Inlets

Proposed changes

Proposed rust doc comment for creating a TCP inlet: Create a TCP Inlet

Closes https://github.com/build-trust/ockam/issues/6643

Checks

  • [x] All commits in this Pull Request are signed and Verified by Github.
  • [x] All commits in this Pull Request follow the Ockam commit message convention.
  • [x] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • [x] I have read and accept the Ockam Community Code of Conduct.
  • [x] I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

ivor11 avatar Sep 09 '24 22:09 ivor11

Hi @ivor11, can you please:

  • Check the commits convention and adjust your commit for this PR (note: chore: fix the create inlet help message is fine as a message)

  • Create a separate pull request to be added as a contributor?

etorreborre avatar Sep 11 '24 07:09 etorreborre

Thanks @etorreborre, I've edited the commit message as per your suggestion and created a PR for adding myself as a contributor https://github.com/build-trust/ockam/pull/8462

ivor11 avatar Sep 14 '24 13:09 ivor11

Hi @ivor11 you need to use the same email for your contributions as the one listed in your CLA acceptance. Can you please either change this PR commit or open a new CLA PR to fix your email address?

etorreborre avatar Sep 16 '24 09:09 etorreborre

Hi @etorreborre, I've fixed the email on the PR commit, could you please run the CI checks again

ivor11 avatar Sep 17 '24 23:09 ivor11

Hi @etorreborre, can you please run the checks again and merge this PR?

ivor11 avatar Nov 14 '24 17:11 ivor11