ockam icon indicating copy to clipboard operation
ockam copied to clipboard

test(cmd_authenticated): Add property-based testing for argument parsing

Open younes-io opened this issue 2 years ago • 6 comments

  • Implemented property-based tests using proptest for 'authenticated get' and 'list' commands

  • Tests generate a range of IP addresses, ports, and IDs to verify argument parsing robustness

Current behavior

Proposed changes

Checks

  • [X] All commits in this Pull Request are signed and Verified by Github.
  • [X] All commits in this Pull Request follow the Ockam commit message convention.
  • [X] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • [X] I have read and accept the Ockam Community Code of Conduct.
  • [X] I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

younes-io avatar Dec 25 '23 20:12 younes-io

Can someone help me fix the commit msg ?

younes-io avatar Jan 13 '24 08:01 younes-io

@younes-io sure, do you need guidance on how to change a commit message, or what a commit message should be to meet our rules?

SanjoDeundiak avatar Jan 21 '24 11:01 SanjoDeundiak

@SanjoDeundiak, I'd appreciate your help on how to change the commit. Should I do a git rebase?

younes-io avatar Jan 21 '24 12:01 younes-io

@younes-io yes, I usually do git rebase or use the UI (Sublime Merge). However, if only the last commit message should be changed, you can do git commit --amend. After you've changed the commit message, you'll need to git push --force-with-lease. More detailed explanation can be found here. Let me know if you need further help!

SanjoDeundiak avatar Jan 21 '24 12:01 SanjoDeundiak

@SanjoDeundiak I tried to, but since the commit isn't the last, I don't have the Amend option...

younes-io avatar Jan 21 '24 15:01 younes-io

@younes-io you would also need to remove the merge commit. You can do it with git rebase develop

SanjoDeundiak avatar Jan 21 '24 15:01 SanjoDeundiak

Closing because this keeps failing and I get a million emails a day... even with the commits.. it's not solved..

younes-io avatar Mar 09 '24 18:03 younes-io