ockam
ockam copied to clipboard
build-trust
ci: notice file issue #626 updates
Current behavior
Currently the NOTICE file is out of date with no automated way to update that easily.
Proposed changes
Added job to all.yml to run the parseCrates.sh script. It will check if the notice file needs updating and fail if it's out of date. Cargo-deny can be piped into the parseCrates.sh file and it will create an updated NOTICE file in a similar format to the current version.
Checks
- [X] All commits in this Pull Request are signed and Verified by Github.
- [X] All commits in this Pull Request follow the Ockam commit message convention.
- [X] I accept the Ockam Community Code of Conduct.
- [X] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.
Hello @kat-coding just wanted to check in on this PR, are you still working on it?
@metaclips I pulled this PR branch locally and made some changes but I'm not sure how to push them here? Should I push to my own fork and make a new PR?
@metaclips I pulled this PR branch locally and made some changes but I'm not sure how to push them here? Should I push to my own fork and make a new PR?
@Wryhder yes please, create a new PR.