ockam icon indicating copy to clipboard operation
ockam copied to clipboard

Change `ockam tcp-listener create` command for --at <NODE> and <ADDRESS>

Open mrinalwadhwa opened this issue 3 years ago • 0 comments

Currently:

» ockam tcp-listener create --help

ockam-tcp-listener-create 0.68.0
Create tcp listener on the selected node

USAGE:
    ockam tcp-listener create [OPTIONS] <BIND>

ARGS:
    <BIND>

OPTIONS:
    -h, --help           Print help information
    -n, --node <node>    Override the default API node [default: default]
    -q, --quiet          Do not print trace messages
    -v, --verbose        Increase verbosity of trace messages
    -V, --version        Print version information

We want to change it to:

» ockam tcp-listener create --help

ockam-tcp-listener-create 0.68.0
Create tcp listener on the selected node

USAGE:
    ockam tcp-listener create [OPTIONS] <ADDRESS>

ARGS:
    <ADDRESS>   Address for this listener (eg. 127.0.0.1:7000)

OPTIONS:
    -h, --help           Print help information
        --at <NODE>      Node at which to create the listener [default: default]
    -q, --quiet          Do not print trace messages
    -v, --verbose        Increase verbosity of trace messages
    -V, --version        Print version information
  • [ ] rename <BIND> positional argument to address
  • [ ] rename -n, --node <node> option to --at <NODE>

The code for this is here: https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/tcp/listener/create.rs


We love helping new contributors! If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion. If you're looking for other issues to contribute to, checkout issues labeled - https://github.com/build-trust/ockam/labels/good%20first%20issue or https://github.com/build-trust/ockam/labels/help%20wanted

mrinalwadhwa avatar Aug 07 '22 04:08 mrinalwadhwa