ockam
ockam copied to clipboard
Switch to using Handle everywhere we interact with Workers
Handle should be moved to ockam_node and used everywhere we interact with Workers in request-response manner (e.g. VaultSync)
I've been working on this for a bit. hraesvel/tranpose_handle some of the highlights are listed below.
- I've moved Handle into
ockam_node::handle
bacea17a5280e529b82750da15f31f3d48b7da04 - Added a few methods to expose the fields e5093a2df2aae770b543fcd1bd7b4083b007d13a & e5093a2df2aae770b543fcd1bd7b4083b007d13a
- fix code that broke due to the move.
Also I've started to switch VaultSync
over to Handle
hraesvel/impl_handle_for_vault_sync.
- convert
VaultSync
548e3b21e6c27996a757361077fa375a05f98a78, as for label the methods todepricated & allow unused
I figured that was the best way to both appease the#[deny(...)]
and not break code.- I actually commented out
deprecated
attributes out in a later commit. would like your input. Eventually, once all the functions are converted these will be labeled as unused.
- I actually commented out
- convert
hasher.rs
to usecall()
methods 4a39c39fc0a31d3348c133807bb500101bc19fa9 - remainder is a bunch of temporary fixes.
~~Want to talk about the conversion that was done to hasher.rs
I found 2 variations, the difference is minor but it really comes down to use or not use turbo fishing.~~
~~turbo fish~~
~~define variable types~~
~~I'm leaning towards the turbo-fish. Though the main problem is that ResultMessage
has to be converted with into
to be useable. It's kind of a gotchya, I found this confusing at first when my tests were first failing.~~
edit: Added a call()
method to VaultSync
that wraps around Handle::call()
Of course, I wouldn't mind someone weighing in if they can clean this up.