harmony icon indicating copy to clipboard operation
harmony copied to clipboard

Generate cpanfile with feature information

Open CyberShadow opened this issue 4 years ago • 1 comments

Details

Loading feature information from CPAN::Meta is currently not supported by Module::CPANFile, so do this by hand for now.

Fixes cpanm not installing dependencies for enabled features (as it prefers reading the cpanfile over MYMETA.*).

Additional info

  • Upstream bug: https://github.com/miyagawa/cpanfile/issues/55

Test Plan

It may make sense to add some automation to verify that the generated cpanfile matches the one in version control. Maybe something like this:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index d0839a88a..a3cf15eb7 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -57,3 +57,7 @@ jobs:
         run: 'perl checksetup.pl --no-database --default-localconfig --no-templates'
       - name: Run tests
         run: 'prove -Ilocal/lib/perl5 t'
+      - name: Re-generate cpanfile
+        run: 'make cpanfile'
+      - name: Check for modified files
+        run: 'git diff --exit-code'
diff --git a/createaccount.cgi b/createaccount.cgi
old mode 100644
new mode 100755

CyberShadow avatar Dec 11 '21 10:12 CyberShadow

With this applied it looks like some dependencies that checksetup.pl thinks are required aren't being installed.

justdave avatar Feb 29 '24 16:02 justdave