script-server icon indicating copy to clipboard operation
script-server copied to clipboard

History for Parameters

Open Daniel-Engelmann opened this issue 5 months ago • 4 comments

Would a history feature for previously entered parameters be useful for this project?

At our company, we use the script-server and it is tedious to re-input the parameters for a script every time you want to use it. Most of the time, you want to run the script multiple times with the same parameters.

I created a basic way to save parameter history. It stores the history in the browser and offers options for executing the script with parameters, favorites, and limits the maximum number of entries in the history (for non-favorites) to ten. When navigating to the script, it also enters all parameters of the top entry (from the histories).

Image Image

I would be happy to provide the code for this feature if it fits into the project. It's my first time implementing something like this, so the code isn't great.

Daniel-Engelmann avatar Aug 01 '25 07:08 Daniel-Engelmann

Hi @Daniel-Engelmann that's a great idea There is a similar issue like this: https://github.com/bugy/script-server/issues/377#issue-768759381

I think reusing existing history is slightly better option, especially because it's stored on a server

However, we can take your changes as a quick improvement here. The only thing i would ask for, is to move history to the top panel, somewhere on the far right side (and without text). For me it fits better there

bugy avatar Aug 01 '25 07:08 bugy

All right, I moved it to the header bar. Are there any other design aspects that should be changed?

Image Image Image

Also, how exactly can I upload my code? I already created a feature branch locally, but how do I push my code to the repo/create a pull request? This is my first time contributing to a project, so I have no idea how to do it.

Daniel-Engelmann avatar Aug 01 '25 13:08 Daniel-Engelmann

Hi, thanks! From design perspective i would ask to remove background and outline from the button Everything else looks cool to me

Regarding PR: you can push your branch to GitHub (i guess it should be a forked repository) And then you can open pull requests tab in my main script server repo, and click "new" button

bugy avatar Aug 01 '25 14:08 bugy

Thanks ^^ here is the pull request

https://github.com/bugy/script-server/pull/800

Daniel-Engelmann avatar Aug 01 '25 14:08 Daniel-Engelmann