vscode-open-in-github icon indicating copy to clipboard operation
vscode-open-in-github copied to clipboard

Published 20 hours ago • verified publisher icon bugthesystem

If current branch is not remote, browser showing 404 page as expected.

Open asimolmez opened this issue 7 years ago • 2 comments

I think you should add an informed message when current branch is not on Github. For the user experience, other developers can be perceived as not working. Only suggestion.

asimolmez avatar Mar 18 '17 07:03 asimolmez

@asimolmez Thank you for your feedback, I'll have a look at to this asap 👍

bugthesystem avatar Apr 18 '17 10:04 bugthesystem

@ziyasal Even better than an error message would be for this to work how PHPStorm does: don't open based on the branch, but based on the SHA of the current commit. That way if you've checked out a branch but you haven't made a change to a given file, the SHA hasn't changed, and it'll be a correct link on GitHub. The vast majority of the time I'm trying to view a file on GitHub, I haven't changed that file locally, or if I have, I've pushed it to GitHub.

Just a thought...

martynchamberlin avatar Oct 31 '17 13:10 martynchamberlin