FireSharp
FireSharp copied to clipboard
Found possible error in PrepareUri, Class RequestManager
When no auth queryStr start with & instead ?
The proposal to fix.....
private Uri PrepareUri(string path, QueryBuilder queryBuilder) { var authToken = !string.IsNullOrWhiteSpace(_config.AuthSecret) ? $"{path}.json?auth={_config.AuthSecret}" : $"{path}.json";
var queryStr = string.Empty;
if (queryBuilder != null)
{
queryStr = string.IsNullOrWhiteSpace(_config.AuthSecret)
? $"?{queryBuilder.ToQueryString()}"
: $"&{queryBuilder.ToQueryString()}";
}
var url = $"{_config.BasePath}{authToken}{queryStr}";
return new Uri(url);
}
Or another solution is add a ? at the end of 127 line
private Uri PrepareUri(string path, QueryBuilder queryBuilder) { var authToken = !string.IsNullOrWhiteSpace(_config.AuthSecret) ? $"{path}.json?auth={_config.AuthSecret}" : $"{path}.json?";
var queryStr = string.Empty;
if (queryBuilder != null)
{
queryStr = $"&{queryBuilder.ToQueryString()}";
}
var url = $"{_config.BasePath}{authToken}{queryStr}";
return new Uri(url);
}