go-serial icon indicating copy to clipboard operation
go-serial copied to clipboard
verified publisher icon bugst

enumerator: fill in 'product' and 'manufacturer' on linux

Open bearsh opened this issue 2 years ago • 2 comments

handling of values of 'product' and 'manufacturer' is commented on linux, see https://github.com/bugst/go-serial/blob/e381f2c1332081ea593d73e97c71342026876857/enumerator/usb_linux.go#L75-L94

is there a specific reason for this? can this be enabled?

bearsh avatar Feb 13 '23 15:02 bearsh

I was going to ask for the same thing, I see there was support in darwin too:

https://github.com/bugst/go-serial/blob/e381f2c1332081ea593d73e97c71342026876857/enumerator/usb_darwin.go#L73

I'd find this useful

even if we can get the version (bcdDevice)

If we had those things I could switch from my implementation for device lookup here https://github.com/redhat-et/jumpstarter/blob/main/pkg/drivers/jumpstarter-board/udev.go into using go-serial completely.

mangelajo avatar Jul 28 '23 10:07 mangelajo

I'm sorry to resurface an old issue, but I'm also interested: why aren't these reported? If it's that some devices error out, I'd rather have the product set on the ones that work rather than have them ALL blank (if possible)

Edit: ah, I forgot about libudev. Is this done to remove dependencies on cgo?

randomouscrap98 avatar Mar 01 '24 16:03 randomouscrap98