bugsnag-source-maps icon indicating copy to clipboard operation
bugsnag-source-maps copied to clipboard

added support for monorepo

Open ricardoribas opened this issue 2 years ago • 4 comments

Goal

When we setup bugsnag react native package, it doesn't support 100% monorepo. Apparently, the best option right now to support that is to perform hoisting on packages (if you are using yarn workspaces). The idea is to support a standalone package, but also monorepo.

Design

To better locate the bugsnag sourcemap package. When executing under the xcode build phases, the relative path will not work if we are working under monorepo projects. With this approach, the problem gets solved.

Changeset

Changed binary in order to target the right package location

Testing

Right now i just tested on my project. I would need some guidance in order to test it properly and not affect other developers. Feedback is needed 😄

ricardoribas avatar Aug 30 '23 07:08 ricardoribas

Hi @ricardoribas Thank you for opening this pull request, I've added it to our backlog and one of our engineers will take a look when priorities allow.

clr182 avatar Sep 21 '23 09:09 clr182

Thanks a lot @clr182. As this is my very first PR to a library, let me if there is anything I could do to improve.

ricardoribas avatar Sep 21 '23 09:09 ricardoribas

@clr182 do you have any update on this?

ricardoribas avatar Dec 19 '23 14:12 ricardoribas

Hi @ricardoribas

We appreciate your patience here.

Unfortunately we don't have any updates on an ETA yet, but this remains on our backlog to be looked at when priorities allow.

We will make sure to post any updates here when they are available.

mclack avatar Jan 02 '24 15:01 mclack