bugsnag-js icon indicating copy to clipboard operation
bugsnag-js copied to clipboard

Fix electron v8

Open djskinner opened this issue 1 year ago • 2 comments

Goal

Fix the electron tests on v8 branch

Design

Set max_body_size: 25mb on the verdaccio config (local npm where packages are published for the electron tests) to allow for the increased size of @bugsnag/react-nativein v8.

Note the increase in size is expected and is because it contains both prefabs (which are unstripped and have a ton of extra debug info), and the classic JNI .so files. Depending on peoples builds only one gets used, and prefabs are processed before being included in the app. The size of .apk files doesn't get affected, just the .aar files.

djskinner avatar May 16 '24 15:05 djskinner

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.24 kB 13.75 kB
After 45.24 kB 13.75 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by :no_entry_sign: dangerJS against 37b6b0db3996e50b6b240573be0670b97dd1819d

github-actions[bot] avatar May 20 '24 10:05 github-actions[bot]

@djskinner you can resolve the electron issue by pinning @vercel/webpack-asset-relocator-loader to 1.7.3 - a new version was released last week and seems to have introduced this issue. I also have the fix in https://github.com/bugsnag/bugsnag-js/pull/2143

gingerbenw avatar May 21 '24 10:05 gingerbenw