Disable phpstan?

Open roxblnfk opened this issue 1 year ago • 2 comments

phpstan produces a lot of false-positive alerts.

I'm considering to turn it off in CI.

Jun 23 '24 14:06 roxblnfk

Let's add Rector to the project. Then we could use Rector + Phpstan for fixing type errors. Also you can disable some fuzzy checks like https://github.com/buggregator/trap/blob/master/phpstan-baseline.neon#L1019

Jun 29 '24 17:06 Kaspiman

I think Rector may break our elegant code style. Let's add it without CI, as a composer command. And without changes in SRC because I'm coding a big feature in progress and I don't want to have conflicts 🙀

After local testing we will consider adding it in CI

Jun 29 '24 19:06 roxblnfk