coolreader icon indicating copy to clipboard operation
coolreader copied to clipboard

Switching language in TTS according to the langauge of the document

Open mcepl opened this issue 6 years ago • 6 comments

(this is roughly the same as this Sourceforge bug, but reformulated)

I use CoolReader on Android (the latest version out of F-Droid repository)

I guess there is plenty of people who read books in multiple languages (e.g., majority of those who are native non-English have some English books together with books in their native language). If we want to use TTS on them (and thank you, that Coolreader has actually working FLOSS TTS plugin built-in, contrary to some others who have it as a proprietary add-on), we have to switch language in the system settings otherwise I get a bizzare Czech engine trying to pronounce English, which gets too much pretty fast (or I guess, most maintainers are Russians, I cannot even imagine how the nice Harry Potter fanfiction sounds through the Russian language engine).

Considering that every EPub book have its language defined in dc:language element, it shouldn't be that complicated to pull this information out of it and send it (and possibly reinitialize) TTS engine after the start of new book.

Thank you for quite cool reading program!

mcepl avatar Jan 15 '19 10:01 mcepl

Simple implementation added in #169.

virxkane avatar Sep 29 '20 17:09 virxkane

Implemented: device-2021-08-20-082927-m

But language switching for text fragments in multilingual documents is not implemented.

virxkane avatar Aug 20 '21 04:08 virxkane

How far is the f-droid build from the master?

mcepl avatar Aug 21 '21 20:08 mcepl

How far is the f-droid build from the master?

Now available 3.2.58: https://f-droid.org/en/packages/org.coolreader.fdroid/. Thanks to @pazos #284. This feature is available in 3.2.58.

After 3.2.58 added #304, #306, #307. Changes from 3.2.58 to master: https://github.com/buggins/coolreader/compare/cr3.2.58...master

virxkane avatar Aug 22 '21 03:08 virxkane

@virxkane: thanks for the thanks, but we need to thank @linsui, who did the work on fdroid's repos.

pazos avatar Aug 25 '21 18:08 pazos

@virxkane: thanks for the thanks, but we need to thank @linsui, who did the work on fdroid's repos.

ok and thanks to @linsui too.

virxkane avatar Aug 26 '21 02:08 virxkane