coolreader icon indicating copy to clipboard operation
coolreader copied to clipboard

tts hide toolbar

Open teleshoes opened this issue 3 years ago • 5 comments

when clicking outside of the TTS toolbar, show/hide the TTS toolbar, instead of stopping TTS.

this fixes issue #320

many thanks to @plotn for the idea and implementation outline!

p.s.: the majority of this PR is whitespace/indentation. skip the first commit to see just the actual changes

teleshoes avatar Mar 13 '22 17:03 teleshoes

@teleshoes, go back to conversations with good ideas ))

plotn avatar Mar 13 '22 20:03 plotn

haha, i guess it was my idea, though you fixed it by having it toggle instead of dedicated toolbar button to hide. joint effort anyway

teleshoes avatar Mar 13 '22 20:03 teleshoes

I mean any other good ideas, not this case.

plotn avatar Mar 13 '22 20:03 plotn

yea, i PR'd just this one simple idea, for least-change to most directly resolve issue #320, with a minimum of things anyone could reasonably object to. personally, im including a few more of your ideas in my own build

edit: in case i misunderstood you yet again...i will happily continue posting any ideas where you and others can find them :D

teleshoes avatar Mar 13 '22 21:03 teleshoes

@teleshoes , as for me it would be suitable on my discussion board: https://github.com/plotn/coolreader/discussions - you're always welcome (unfortunally "base" project has no discussion board)

plotn avatar Mar 15 '22 20:03 plotn