phpvideotoolkit-v2 icon indicating copy to clipboard operation
phpvideotoolkit-v2 copied to clipboard

php syntax warning

Open ryangroth5 opened this issue 6 years ago • 1 comments

getting a syntax error with PHP 7.3.2, "continue is the same as break in a swtich" the following patch suppresses the error and will work for any version of PHP:

--- a/src/PHPVideoToolkit/Mime.php~	2019-02-06 20:11:38.000000000 +0000
+++ b/src/PHPVideoToolkit/Mime.php	2019-03-01 15:57:29.245315100 +0000
@@ -186,7 +186,7 @@
 
                          default:
                             // date, ldate, ledate, leldate, beldate, lebelbe...
-                            continue;
+                            break;
                       }
                    }
                

ryangroth5 avatar Mar 01 '19 16:03 ryangroth5

have same with php 7.3.3 but only if resizing from small to larger video:

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/vendor/buggedcom/phpvideotoolkit/src/PHPVideoToolkit/Mime.php on line 189

blue-eyed-devil avatar Apr 09 '19 10:04 blue-eyed-devil