Robert J. Lang

Results 193 comments of Robert J. Lang

> We should change the label of the field and/or its description to clarify that this is NOT about truncating the length of the log messages that are being saved...

PR updated with your suggestion, thanks. Dunno why the phpcs command is failing, but it doesn't seem related to any of the code changes.

Fixed that, but more PHPCS complaints in layout.admin.inc, which is not part of this PR.

I rebased it, and PHPCS is now happy. Tests restarting.

Sounds good to me. Both changes made, PR updated.

As food for thought, CiviCRM posts a notice on its dashboard for each release as an expandable fieldset. The expanded version is still generic, though; you need to click through...

Considering the combination of arrow and bar: an up-arrow tells me "the normal order of of this thing goes from bottom to top," and "the normal order" is clearly lexicographic...

I agree with @olafgrabienski that it's OK to use the same or similar symbols in different places when they're unlikely to be confused, but the "arrow-up"/"arrow-down" examples above (first pair)...

PHPCS flagged coding standards in settings.php. Although the flagged lines are not part of this PR's changes, it might be appropriate to make the changes here. There is the question...