vrt-ruby

vrt-ruby copied to clipboard

Let VRT::Map#find_node accept nil values

4

# Description Make `VRT::Map#find_node` more durable to unexpected input - Resolves: https://github.com/bugcrowd/vrt-ruby/issues/32 - Also adds some much needed spec coverage around `VRT::Map#find_node` # Checklist: - [x] I have made corresponding...

adamrdavid

This error is thrown at: https://github.com/bugcrowd/vrt-ruby/blob/master/lib/vrt/map.rb#L21: ```ruby def find_node(string, max_depth: 'variant') # return nil unless valid_identifier?(string) @_found_nodes[string + max_depth] ||= walk_node_tree(string, max_depth: max_depth) end ``` #### when param: string ==...

adamrdavid

Now that we have `mappings` and `maps`, we need to rename `Vrt::Map` to be something like `Vrt::Hierarchy` or something similar. I think that title more accurately describes what it is.

maschwenk