ladybird-gtk4 icon indicating copy to clipboard operation
ladybird-gtk4 copied to clipboard

Meta: Build with a two-stage build where we install Lagom first

Open ADKaster opened this issue 2 years ago • 6 comments

Depends on #3 Depends on https://github.com/SerenityOS/serenity/pull/20417

ADKaster avatar Aug 08 '23 05:08 ADKaster

Ready to go on this guy

ADKaster avatar Aug 11 '23 03:08 ADKaster

Where did WebContentMain go? Without it, how do we set WebContent, such as configuring the event loop and the request manager?

bugaevc avatar Aug 11 '23 05:08 bugaevc

WebContent comes from the serenity repo. The contents are almost exactly the same. By building it without Qt (ENABLE_QT=OFF), we get the serenity RequestServer implementation. I think there's some room to mess with the way that we load the "plugins" to make them more customisable and out-of-treeable.

ADKaster avatar Aug 11 '23 05:08 ADKaster

CMake Error at CMakeLists.txt:21 (find_package):
  Could not find a package configuration file provided by "Lagom" with any of
  the following names:

    LagomConfig.cmake
    lagom-config.cmake

  Add the installation prefix of "Lagom" to CMAKE_PREFIX_PATH or set
  "Lagom_DIR" to a directory containing one of the above files.  If "Lagom"
  provides a separate development package or SDK, be sure it has been
  installed.

This is just trying to run ninja.

bugaevc avatar Aug 11 '23 09:08 bugaevc

Ah. I forgot to add the actual build instructions.

If you build the flatpak it works 😬. I'll whip something up for local builds

ADKaster avatar Aug 11 '23 11:08 ADKaster

All right, after an embarrassing number of pushes to serenity master, this should all work now. Let me know if the new build instructions make sense

ADKaster avatar Aug 12 '23 02:08 ADKaster