Dániel Buga

This line is a bit naive as it doesn't allow for spaces in paths: https://github.com/lapce/lapce/blob/master/lapce-proxy/src/terminal.rs#L63 This means that the `program` in `which::which(program)` is basically `C:\Program` which is nonsense. I'm not...

Might be a bug in https://github.com/Byron/trash-rs since it implements moving to bin.

While technically correct, I wouldn't introduce a mutable variable that really doesn't have to be mutable. You can fix the weird formatting by extracting the `.len() - 1` part into...

I find the `delta: Point` a bit weird. I understand e-g lacks a distinct `Vec2d` type, but here it would make the signature cleaner, I think.

It's possible to hide an extension trait in prelude and sidestep the `Angle` issue that way, if I understand the problem correctly. But after my `polar` brainfart, who knows 🤔...

Nah the dev setup guide is clear I think. WSL instructions should be identical to Ubuntu but I'll check and update it if necessary. This issue is just a point...

All right, this isn't Transform-specific, but I burnt myself with this today. What would you think about sprinking `#[must_use]` around rather liberally? I was chasing a bug in embedded-layout where...

I think it can go on constructors and field accessors, conversion functions (like those of `Angle`) in general - if the result isn't used, what's the point? On the other...

To clarify, my comment tried to point out an ambiguity with regards to the Top alignment (top of the letter, vs top of the "em box").

> The reason for this is that TextBox wraps the draw target in a Clipped adapter Oh, that's bad. ~A simple enough workaround would be to pass the target as...