passwall-extension-old icon indicating copy to clipboard operation
passwall-extension-old copied to clipboard

Use antd for ui

Open yasintz opened this issue 6 years ago • 5 comments

Instead of uikit, antd used on the web and desktop should be used.

yasintz avatar Apr 25 '20 23:04 yasintz

I agree. We must use almost same technologies in all clients. @bufgix, beacuse you are the author of this repo, asking you first. Do you want to work on this?

yakuter avatar Apr 25 '20 23:04 yakuter

My purpose is to keep the plugin size minimum. That's why I use UIKit. But if you want to change, we can switch to antd

bufgix avatar Apr 26 '20 09:04 bufgix

Is antd so big in size? I heard that is is fast.

yakuter avatar Apr 26 '20 11:04 yakuter

resim

Also, we use vue bundle of antd size may be bigger

bufgix avatar Apr 26 '20 11:04 bufgix

Bundle size may not be an issue for an extension. I couldn't find a document reference for this but as far as I understand extensions store its resources locally. On my Mac extension sources stored in the below directory. HOME_DIRECTORY/Library/Application Support/Google/Chrome/Default/Extensions/EXTENSION_ID

Since there is no network request to download resources, bundle size might be neglected.

a similar opinion from stackoverflow. https://stackoverflow.com/a/12963902

mtoygar avatar Apr 27 '20 18:04 mtoygar