Roger Meier
Roger Meier
> Just commenting out that line made it work (I did not have to update the gem and/or set the audience option). IMHO we would need to have a flag...
the `redirect_uri` is a configuration parameter, see https://github.com/omniauth/omniauth_openid_connect?tab=readme-ov-file#usage , maybe share your config and some more details about the software you are using along with omniauth_openid_connect
No idea why you mention https://github.com/nov/rack-oauth2/blob/70da234801c53a116c2d8e126bb09f237824af5a/lib/rack/oauth2/client.rb#L71, this gem is not depending on it https://github.com/omniauth/omniauth_openid_connect/blob/master/omniauth_openid_connect.gemspec#L30:L31 . maybe set all the endpoint explicit and disable discovery ?
not sure why you need required_state, I suggest removing that. A config that works: https://docs.gitlab.com/ee/administration/auth/oidc.html?tab=Azure+OAuth+2.0#configure-microsoft-azure
@stanhu looks good, but rubocop is complaining. Could you fix that? So we can merge this.
I personally think that this would also require a `locked-in` and/or `open-for-a-multireligion-humanized-world-of-peace` field 😸 .
@nov Could you maybe provide some feedback here?
@nov ok, you don't like this PR but how would you solve it?
@rgmz regarding your question within https://github.com/gitleaks/gitleaks/pull/1536#issuecomment-2381440822 , I would rather prefer a list options within extend, such as the following: ```toml [extend] disabledRules = [ "private-key", "generic-api-key", "jwt" ] ```...
nice @rgmz , I like it! @zricethezav wdyt?