Hide for tablets and phones?

[samglover]

Now that responsive design has become more or less standard, I think it would be a good idea to add an option to disable the toolbar on tablets and phones.

[aronmarriott-smith]

Hey Sam,

If the screen is not wide enough the Digg Digg floating bar is hidden. This is done using JavaScript in a file named "floating-bar.js" Does this work for you? (You can test it resizing your browser window.)

[samglover]

Maybe this is a bug report, then. It doesn't work for me. It's always there, hiding to the right of the screen (see lawyerist.com for an example).

On Wed, Jan 9, 2013 at 10:24 AM, Aron Marriott-Smith < [email protected]> wrote:

Hey Sam,

If the screen is not wide enough the Digg Digg floating bar is hidden. This is done using JavaScript in a file named "floating-bar.js" Does this work for you? (You can test it resizing your browser window.)

— Reply to this email directly or view it on GitHubhttps://github.com/bufferapp/diggdigg/issues/5#issuecomment-12052103.

[aronmarriott-smith]

I had a look at lawyerist.com, it could be a bug. Usually the floating bar floats on the left hand side. Have you checked the setting "Choose how far from to the left of the content Digg Digg is placed" and tried setting it to 60?

[samglover]

Yes, the left-side default is a pain for blogs with the content on the right side (this applies to a lot of websites). I've had to set the offset to a fairly large negative value. We've had reports of the Digg Digg bar covering the content on some screens. My guess is that it could be related.

On Wednesday, January 9, 2013, Aron Marriott-Smith wrote:

I had a look at lawyerist.com, it could be a bug. Usually the floating bar floats on the left hand side. Have you checked the setting "Choose how far from to the left of the content Digg Digg is placed" and tried setting it to 60?

— Reply to this email directly or view it on GitHubhttps://github.com/bufferapp/diggdigg/issues/5#issuecomment-12060491.

[aronmarriott-smith]

That makes sense now, the code is not set up to handle negative integers, and explains why it still appears on smaller screen sizes. The solution would be to add an option to float on the left or the right side, independent of the distance from content.

[samglover]

That would be awesome, because the way it gets added to images now also makes it not show up at the top, sometimes (and it doesn't matter whether the offset integer is positive or negative). Compare these posts, for example:

Regular image: http://lawyerist.com/the-pitfalls-of-sentence-adverbs-in-legal-writing/ WordPress featured image: http://lawyerist.com/exploring-new-practice-areas/ Post image using the Thesis theme: http://lawyerist.com/legal-writing-resolutions-for-2013-part-two/

On Wed, Jan 9, 2013 at 1:24 PM, Aron Marriott-Smith < [email protected]> wrote:

That makes sense now, the code is not set up to handle negative integers, and explains why it still appears on smaller screen sizes. The solution would be to add an option to float on the left or the right side, independent of the distance from content.

— Reply to this email directly or view it on GitHubhttps://github.com/bufferapp/diggdigg/issues/5#issuecomment-12061951.

[sbxcr]

Unhook it from the content within the single loop. Something like this:

if ( wp_is_mobile() ) { remove_filter('the_excerpt', 'dd_hook_wp_content'); remove_filter('the_content', 'dd_hook_wp_content'); }

Drop that in right before the_content() or the_excerpt(). In light testing (current site neither launched or fully tested), the above seems to work.