bufdev

protoc-gen-go: consider applying M option to prefixes

14

I was testing out the v2 plugin and got this: ``` 2019/11/26 11:17:11 WARNING: Missing 'go_package' option in "bufbuild/buf/image/v1beta1/image.proto", please specify: option go_package = "bufbuild/buf/image/v1beta1;bufbuild_buf_image_v1beta1"; A future release of protoc-gen-go...

encoding: provide canonical output format

44

https://go-review.googlesource.com/c/protobuf/+/151340 added internal/detrand to denote to users that they should not rely on the stability of output. This is used for example in encoding/protojson to add a space between json...

reflect/protodesc: automatically create dynamic extension types for NewFiles

17

This is likely not possible or not desirable, but: `protojson.UnmarshalOptions` uses the given `Resolver` to potentially resolve encoded extensions https://github.com/protocolbuffers/protobuf-go/blob/master/encoding/protojson/decode.go#L165 However, `protojson.MarshalOptions` only uses the given `Resolver` to resolve `google.protobuf.Any`...

Move lint rules to a FileDescriptorSet-based library

9

This is more to start a discussion than anything concrete, not sure if you'd be interested in this at all. So a few points: - Protoreflect is a magical library,...

YAML output issues

6

Similar to #306, using same commit of both api-linter and googleapis/googleapis. Issues: - Arrays elements printed for files with no problems. - I think this invalid YAML but might be...

protoparse: options in descriptors are not serialized the same as with protoc

25

``` --- FAIL: TestEnvoyIncludeImports/envoy/config/filter/network/thrift_proxy/v2alpha1 (0.07s) require.go:1159: Error Trace: goprotoctest_test.go:639 goprotoctest_test.go:505 Error: Should be true Test: TestEnvoyIncludeImports/envoy/config/filter/network/thrift_proxy/v2alpha1 Messages: diff detected: protoc-goprotoc File.slice[9].MessageType.slice[9].XXX_sizecache: 335 != 325 File.slice[9].XXX_sizecache: 2217 != 2207 XXX_sizecache: 38689...

I can do this if you want. What I'm thinking: - Get all the `unittest.*proto` files from https://github.com/protocolbuffers/protobuf/tree/master/src/google/protobuf on an automated basis, either directly in a Golang test, or via...

Parser does not include Well-Known Types SourceCodeInfo

3

Example: ```proto // file: foo/v1/foo.proto syntax = "proto3"; package foo.v1; import "google/protobuf/duration.proto"; message Bar { google.protobuf.Duration duration = 1; } ``` If you were to parse this via: ```go parser...

`protoc-gen-buf-check-{breaking,lint}` were deprecated in https://github.com/bufbuild/buf/releases/tag/v0.34.0. This was just a rename, the exact same functionality is available via `protoc-gen-buf-{breaking,lint}`. All you need to do throughout the repository is: - `s/protoc-gen-buf-check-breaking/protoc-gen-buf-breaking/` -...

Extensions

4

The docs say: > We implement all proto2 features, except for extensions and the text format. I don't think we can ignore extensions - what does the core js do?