protoc-gen-validate icon indicating copy to clipboard operation
protoc-gen-validate copied to clipboard

Add back grpc c++ support

Open bplotnick opened this issue 7 years ago • 2 comments

We used to be able to pass in use_grpc_plugin to pgv_cc_proto_library until #92. This is useful for c++ applications talking to Envoy.

You can kind of see a use-case in this PR that i let fall by the wayside: https://github.com/envoyproxy/envoy/pull/3857/files

It'd be nice to have this back in some way.

bplotnick avatar Sep 10 '18 00:09 bplotnick

@sesmith177 is this related to your bazel changes, perhaps?

rodaine avatar Sep 11 '18 17:09 rodaine

Yep, it looks like use_grpc_plugin was handled in the protobuf.bzl here, and when we broke the dependency on that file, the functionality did not make it over

sesmith177 avatar Sep 11 '18 19:09 sesmith177