protoc-gen-validate icon indicating copy to clipboard operation
protoc-gen-validate copied to clipboard

proto package names should not be mixed in the same directory

Open zanes2016 opened this issue 6 years ago • 2 comments

We're getting a PGV error in https://github.com/envoyproxy/envoy/pull/3949#issuecomment-409327245 of the following:

proto package names should not be mixed in the same directory

This check exists at https://github.com/lyft/protoc-gen-star/blob/f3b83fca61817e55058744eb1a3c8e2e95a0dada/gatherer.go#L114.

Is there a way to turn this check off?

zanes2016 avatar Jul 31 '18 18:07 zanes2016

Hi @zanes2016 it's a limitation of protoc-gen-go, which protoc-gen-validate is built on top of (via protoc-gen-star). I'm currently working on changes to protoc-gen-star that addresses this.

rodaine avatar Aug 06 '18 18:08 rodaine

Is this still an issue?

rmichela avatar Jun 22 '19 03:06 rmichela