protoc-gen-validate icon indicating copy to clipboard operation
protoc-gen-validate copied to clipboard
verified publisher icon bufbuild

Support for validation of NaN

Open anirudhmurali opened this issue 7 years ago • 1 comments

Support to capture and validate NaN values in: https://github.com/lyft/protoc-gen-validate/blob/master/validate/validate.proto

Reference: https://github.com/envoyproxy/envoy/pull/3905

anirudhmurali avatar Jul 23 '18 20:07 anirudhmurali

This would be very useful. Is this planned to implement? If not, would a contribution for this be accepted?

torkelrogstad avatar Dec 22 '21 13:12 torkelrogstad

Why was this closed? PR isn't merged yet

torkelrogstad avatar Oct 04 '22 21:10 torkelrogstad

Your feedback has been included in bufbuild/protovalidate#69 as this feature aligns with our goals for protovalidate.

I'd like to emphasize that we have no intention of completing this feature in protoc-gen-validate. Our focus is on enhancing protovalidate to accommodate such improvements. As such, I'll be closing the issue, keeping your suggestion in mind as we move forward.

Should you have more ideas or inquiries, please don't hesitate to reach out. Your involvement is crucial to our progress.

elliotmjackson avatar Aug 10 '23 18:08 elliotmjackson