protoc-gen-validate icon indicating copy to clipboard operation
protoc-gen-validate copied to clipboard

PGV is unmaintained

Open rmichela opened this issue 1 year ago • 1 comments

Protoc-gen-validate has no active maintainers. If you would like to take up the mantle, contact @mattklein123 here, or on #protoc-gen-validate channel in the Envoy proxy slack.

rmichela avatar Aug 02 '22 00:08 rmichela

#398 #74

rmichela avatar Aug 02 '22 00:08 rmichela

Hi @mattklein123 - my coworkers and I at @bufbuild would be happy to maintain PGV! It fills a huge gap in the protobuf ecosystem and deserves careful stewardship.

As a company, our incentives are well-aligned with the PGV community's: we want protobuf to be feature-complete and easy to use for personal projects, tiny startups, and giant megacorporations alike, because wider protobuf adoption increases the market for our paid schema registry product.

We'd take care not to break existing PGV users, and we can devote enough time to the project to clear out the issue backlog and possibly support additional languages. We would, of course, keep everything under an Apache 2 license. If the the current stakeholders are amenable, we can iron out a detailed transition plan.

akshayjshah avatar Aug 12 '22 16:08 akshayjshah

@akshayjshah yay! Thank you! This sounds great to me. Please start with the transition plan as I doubt anyone will object but we can leave this comment thread open just in case.

mattklein123 avatar Aug 12 '22 16:08 mattklein123

OK, can do.

Ideally, we'd transfer the repo to bufbuild/protoc-gen-validate. Github maintains redirects, so that keeps things simple: there's only one PGV repo, maintainership is clear, and anyone looking for the old URLs gets automatically redirected to the new home.

This shouldn't be too invasive for most users. Java and Python users should be unaffected, because we'd continue to publish to PyPI and Maven Central using the existing package names. I'm less familiar with the C++ code, but I think the combination of Github redirects and keeping any namespaces unchanged should be workable. Most Go users should be fine, since 99% of them are just go installing the plugin. There are some gaps in this plan (for example, we'd need to change the module name in go.mod, which would break anyone importing the code in module), but IMO they're small.

akshayjshah avatar Aug 12 '22 19:08 akshayjshah

Transferring over SGTM as long as we can be reasonably sure we won't break existing deployments to the greatest extent possible.

mattklein123 avatar Aug 15 '22 14:08 mattklein123

I can't imagine a better steward than the team at buf

derekperkins avatar Aug 25 '22 21:08 derekperkins

Is there a timeline for transferring ownership? In the meantime, could @akshayjshah be added as a maintainer to start handling some outstanding issues/prs?

derekperkins avatar Sep 07 '22 01:09 derekperkins

There is nothing blocking this. We can do the transfer whenever. Also happy to make @akshayjshah a maintainer in the meantime. Let me know.

mattklein123 avatar Sep 07 '22 15:09 mattklein123

The main blocker from our end is just making sure that we won't break lots of users during the transfer. @elliotmjackson has been doing some more detailed investigation to make sure that we've got our bases covered. We'll ping this issue in a bit when we're ready to transfer.

In the meantime, adding me and @elliotmjackson as maintainers sounds good!

akshayjshah avatar Sep 07 '22 20:09 akshayjshah

@akshayjshah @ElliotMJackson I sent you invites, then you will be maintainers. Thank you!

mattklein123 avatar Sep 08 '22 15:09 mattklein123