protoc-gen-validate icon indicating copy to clipboard operation
protoc-gen-validate copied to clipboard

Published 20 hours ago • verified publisher icon bufbuild

Go: fix broken `ensure the imports are used` when importing multiple packages

Open h-otter opened this issue 2 years ago • 8 comments

Hello!! This PR fixes #585.

This problem is caused by the fact that enumName (index (externalEnums $) 0) always returns first enum name, even if enumPackages (externalEnums .) returns multiple packages. With this PR, enumName returns an enum in the specified package.

h-otter avatar Apr 12 '22 11:04 h-otter

Although CI is failing for a reason that is probably unrelated to this patch, do I need to do anything?

h-otter avatar Apr 12 '22 12:04 h-otter

@h-otter thank you so much

mashail avatar Apr 13 '22 21:04 mashail

Maybe #589 contains a fix of CI failure about zlib version.

h-otter avatar Apr 19 '22 02:04 h-otter

@h-otter thanks

mashail avatar Apr 19 '22 07:04 mashail

Is there anything else I need to do to get this PR merged?

h-otter avatar Jun 09 '22 07:06 h-otter

help

fifsky avatar Jun 17 '22 08:06 fifsky

@h-otter longing for this to get merged

mashail avatar Jul 01 '22 18:07 mashail

@snowp @rmichela

After rebase, the CI failure about zlib version was resolved. However, tests are still failing. It is difficult for me to understand why the tests are failing. Would you please help me to fix it?

h-otter avatar Jul 22 '22 04:07 h-otter