modules icon indicating copy to clipboard operation
modules copied to clipboard

[DO NOT MERGE] Add static buf.yaml files for `protovalidate` and `protovalidate-testing`

Open unmultimedio opened this issue 1 year ago • 2 comments

Similar treatment than #579, waiting if/when protovalidate moves to v2: https://github.com/bufbuild/protovalidate/pull/233

unmultimedio avatar Sep 06 '24 21:09 unmultimedio

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 14, 2025, 7:34 PM

github-actions[bot] avatar Sep 06 '24 21:09 github-actions[bot]

What is the deal with this PR?

nicksnyder avatar Feb 13 '25 23:02 nicksnyder

Following up on this -- I recently put up https://github.com/bufbuild/protovalidate/pull/366 to migrate to a v2 buf.yaml file, unaware of some of the obstacles. What is the status of being able to support it? @unmultimedio

smaye81 avatar May 14 '25 17:05 smaye81

Following up on this -- I recently put up bufbuild/protovalidate#366 to migrate to a v2 buf.yaml file, unaware of some of the obstacles. What is the status of being able to support it? @unmultimedio

Sure we're ready if you wanna move to v2, see this comment https://github.com/bufbuild/protovalidate/pull/233#issuecomment-2263399945. If we decide to do it, this PR should be merged first, and then you can bump pv to v2.

Lmk to update+merge this one first.

unmultimedio avatar May 14 '25 17:05 unmultimedio

Sure we're ready if you wanna move to v2, see this comment bufbuild/protovalidate#233 (comment). If we decide to do it, this PR should be merged first, and then you can bump pv to v2.

Lmk to update+merge this one first.

Great. I'm ready if others think we're ok @rodaine @timostamm

smaye81 avatar May 14 '25 17:05 smaye81

Think we're ready to when you are @unmultimedio thanks!

smaye81 avatar May 14 '25 19:05 smaye81

Think we're ready to when you are @unmultimedio thanks!

@smaye81 this is merged! feel free to merge yours, and I'll ping you when the next release for both pv and pvt is being synced here, to sanity check this went fine.

unmultimedio avatar May 14 '25 19:05 unmultimedio

Just merged #366 @unmultimedio. Lmk if things look ok whenever.

smaye81 avatar May 15 '25 14:05 smaye81

Just merged #366 @unmultimedio. Lmk if things look ok whenever.

Sure, this repo will pick things up the next semver release.

unmultimedio avatar May 15 '25 14:05 unmultimedio